fix: Allow passing additional scopes to getAuthClient in examples helper function #489
Conversation
Dunsin-cyber
changed the title
Dunsin-cyber
changed the title
Dunsin-cyber
changed the title
Dunsin-cyber
changed the title
examples/oauth/helper.ts
Outdated
| callback: "http://localhost:8080", | ||
| scopes: ["invoices:read", "account:read", "balance:read"], | ||
| scopes: [ | ||
| "invoices:read", // At least one scope is required to get an access token. |
There was a problem hiding this comment.
Would it be better if all examples pass the scopes they need? because then there isn't the case where they have this scope when they don't need it, or if we want to test a case where the token does not have read permissions
There was a problem hiding this comment.
alright.
yea, I wanted to follow that approach too, but I was trying to avoid having to add comments to most examples explaining that "invoice:read" isn’t actually required for the function, it’s just there because at least one permission needs to be passed.
There was a problem hiding this comment.
@Dunsin-cyber I think all the examples do actually need a specific scope - for those other ones they do need the invoice:read scope (for example the webhook examples). Which one doesn't?
There was a problem hiding this comment.
oh yes, exactly, i've made the fix.
2 participants
The OAuth scopes in
getAuthClientfound inexamples/oauth/helperwere previously hardcoded, making it inflexible. Adding new functionality that required different permissions, such as sending payments, necessitated modifying this core helper function directly.This change refactors the function to accept an optional
additionalScopesarray.Resolves: #488